Raise CHANNELLEN to the maximum of 200 chars defined by rfc1459 #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed my networks like undernet
skralg
approved these changes
Jul 13, 2024
vanosg
requested changes
Jul 20, 2024
Member
vanosg
left a comment
vanosg
left a comment
There was a problem hiding this comment.
Not specifically addressed in this PR but maybe missed when this was implemented- based on the use of last_invchan in chan.c:1779, I think the definition of last_invchan needs to be NICKLEN+CHANNELLEN+1, can you confirm/change?
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: pseudo (see #38)
Patch by: michaelortmann
Fixes: #38
One-line summary:
Raise CHANNELLEN to the maximum of 200 chars defined by rfc1459 and used by networks like undernet
Additional description (if needed):
Its a big bad bug to if eggdrop cant deal with channels with channelnames longer than 80 chars.
Test cases demonstrating functionality (if applicable):
At least themajor network undernet supports the max channel name len of 200.