Fix addbot cmd syntax (and update docs)

[vanosg]

addbot <handle> <address>

    Description: adds a new bot to the userlist with the handle and botaddress given (with no password and no flags)

    Returns: 1 if successful; 0 if the bot already exists

Need to specify address format
-and-
Fix address format!

This probably shouldn't work:

.tcl addbot foo 1.1.1.1/3333/4444
Tcl: 1

.whois foo
HANDLE                           PASS NOTES FLAGS           LAST
foo                              no       0 b               never (nowhere)
  ADDRESS: 1.1.1.1
     users: 4444, bots: 3333

This should probably work:

.tcl addbot foo 1.1.1.1:4444/5555
Tcl: 1

.whois foo
HANDLE                           PASS NOTES FLAGS           LAST
foo                              no       0 b               never (nowhere)
  ADDRESS: 1.1.1.1:4444
     users: 5555, bots: 5555

(^^^ note all ports are 5555, not 4444/5555)

[vanosg]

line 312 of src/tcluser.c:

#ifdef IPV6
    if ((q = strchr(argv[2], '/'))) {
      if (!q[1]) {
        *q = 0;
        q = 0;
      }
    } else
#endif

It looks like the first case posted above was intentionally added for IPv6... any thoughts as to why? Perhaps as an (undocumented) way to getting around having to use []s around an IPv6 address?

[vanosg]

Another case to fix-

.tcl addbot foo \[fe80::20c:29ff:fea7:5864\]:4444
Tcl: 1
.whois foo
HANDLE                           PASS NOTES FLAGS           LAST
foo                              no       0 b               never (nowhere)
  ADDRESS: [fe80
     users: 0, bots: 0

[vanosg]

Based on discussion in channel, the general consensus is that IPv6 is not possible to use without requiring []s around the address. We didn't want to require []s around every IPv6 address, so instead we are going to eventually transition away from using : to separate the port from the IP in favor of a /.

In other words, addbot handle address/botport/userport would be the new format.
In thommey's words, addbot handle [address[/botport[/userport]]]

General roadmap:

1.8.3:

• temp-patch the weirdness and bugs we find right now as best we can without breaking new things
• document to use []s or /s around IPv6 if you want to add a port with the addbot command
  Edit: []s don't work; only document /

1.9.0:

• Make using /s for port separation the default documented method for IPv4 and IPv6, still leaving the current : support in code to maintain backwards compatibility
• Add an 'addserver' command to eventually replace 'set servers {}' in the config

2.0:

• Remove support for syntax using : to separate port from address
• Remove the 'set servers {}' syntax from the config