Multiple mode triggers an error

[crazycatdevs]

Tested with eggdrop 1.10.1 (alpha and stable)

Doing /mode #test +vv Myrddin Viviane, the two are voiced.

In party-line:

[14:14:47] #test: mode change '+vv Myrddin' by CrazyCat!crazycat@admin.zeolia.chat
[14:14:47] * Mode change on #test for nonexistent !

I was pretty sure that the multiple modes were broken down into their components...

[michaelortmann]

I can repeat the bug with irc server solanum-1.0-dev(20240724-4e89f660).

This is a regression since eggdrop 1.10.1rc1, PR #1786 we should milestone/fix for 1.10.2.

PR #1786 added fixcolon() to the code. not only for gotmode(). So there could me multiple similar regressions.

fixcolon() removes a leading ':' from a string. but if there is no leading ':' , which is the case here, it will apply newsplit() to the string: https://github.com/eggheads/eggdrop/blob/develop/src/main.h#L112-L117