Skip to content

Commit

Permalink
Protocol version 5
Browse files Browse the repository at this point in the history
  • Loading branch information
dcramer committed Nov 30, 2013
1 parent 94acc7d commit c1766f0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
9 changes: 8 additions & 1 deletion CHANGES
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Version 6.4.0
-------------

Some major backend changes are introduced in Sentry 6.3.0.
Some major backend changes are introduced in Sentry 6.4.0.

Search
======
Expand All @@ -27,6 +27,13 @@ Additional Changes
- Charts now show tooltips describing the datapoint.
- JavaScript sourcemaps now support embedded sources.
- Stream annotations can now be customized to show any tags (not just number of users).
- Stacktrace frames now get truncated down to a maximum length of 50.

Protocol Version 5
==================

- sentry_version should be sent as '5'.
- The stacktrace interface now accepts a 'frames_omitted' tuple.

Version 6.3.0
-------------
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/client/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ An authentication header is expected to be sent along with the message body, whi

.. data:: sentry_version

The protocol version. This should be sent as the value '4'.
The protocol version. This should be sent as the value '5'.

.. data:: sentry_client

Expand Down
2 changes: 1 addition & 1 deletion src/sentry/testutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
def get_auth_header(client, api_key=None, secret_key=None):
header = [
('sentry_client', client),
('sentry_version', '4'),
('sentry_version', '5'),
]

if api_key:
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/web/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _parse_header(self, request, project):
server_version = auth_vars.get('sentry_version', '1.0')
client = auth_vars.get('sentry_client', request.META.get('HTTP_USER_AGENT'))

if server_version not in ('2.0', '3', '4'):
if server_version not in ('2.0', '3', '4', '5'):
raise APIError('Client/server version mismatch: Unsupported protocol version (%s)' % server_version)

if not client:
Expand Down

0 comments on commit c1766f0

Please sign in to comment.