Don't use weak refs #647
Merged
Don't use weak refs #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the benchmark
permute 10crashes nodejs.In this PR, I investigate not using weak references to see how this affects performance.
Here are preliminary results:
Those benchmarks that heavily use references, like
permute, seem to benefit from not using weak refs.With this change,
permute 10still crashes, but doesn't mention weak references anymore. It looks like we just run out of memory.Please bare in mind that not using weak refs might lead to holding too long onto a references that could have been freed before.