Allocate region variables as "local variables" on previous stack #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
reviewed
Oct 22, 2024
| case Call(_, Ccc(), _, nonglobal, _) => | ||
| C.abort(s"cannot call non-global operand: $nonglobal") | ||
| C.abort(s"cannot call non-global operand: $nonglobal") // why not? |
There was a problem hiding this comment.
@phischu maybe you could discuss this in the meeting briefly?
b-studios
reviewed
Oct 22, 2024
| @@ -385,7 +349,7 @@ object Transformer { | |||
| emit(callLabel(returnAddress, values.map(transform))) | |||
| RetVoid() | |||
|
|
|||
| case machine.NewStack(variable, prompt, frame, rest) => | |||
| case machine.NewStack(variable, prompt, frame, isRegion, rest) => | |||
There was a problem hiding this comment.
will this flag go away when we allocate regions directly on the stack?
There was a problem hiding this comment.
No, we need to know whether we are returning from a region.
|
The last commit depends on #651 |
b-studios
added a commit
that referenced
this pull request
Oct 23, 2024
This enables automatic growing of LLVM's stack once the end is reached (or memory larger than the remaining space is allocated). We can now have much smaller stack sizes than before. For now, I've set the previous 256M stacks to 1KB (which, after initial tests, seems fine). Due to some code repetition I wanted to merge the growing logic of regions with this. I've reverted my attempts since #642 removes the duplicated code anyway. --------- Co-authored-by: Jonathan Immanuel Brachthäuser <jonathan@b-studios.de> Co-authored-by: Philipp Schuster <philipp.schuster@uni-tuebingen.de>
and call special function when underflowing a region
phischu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phischu I hate how this turned out.
When allocating into a region, we cannot know the answer type of that region. This makes it impossible to push a regular return address.
As a workaround, variables are allocated with a special return function, that removes the region from the stack. When underflowing a region, we first call this special function, and then return regularly.
Also, this breaks globals, as the first stack has no previous stack.