Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative: implement transformation in machine-transformer #602

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Alternative: implement transformation in machine-transformer #602

merged 2 commits into from
Sep 24, 2024

Conversation

b-studios
Copy link
Collaborator

This is an alternative to #598

It still needs to be cleaned up (accesses to global should be through proper functions).

@b-studios b-studios mentioned this pull request Sep 24, 2024
Closed
@jiribenes
Copy link
Contributor

Both conceptually and wrt the amount of code, I like this more than #598.

jiribenes
jiribenes approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, explained on the Effekt meeting

@b-studios b-studios marked this pull request as ready for review September 24, 2024 14:39
@b-studios b-studios merged commit 7d49f3f into master Sep 24, 2024
2 checks passed
@b-studios b-studios deleted the feature/llvm-toplevel-val-alternative branch September 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiribenes jiribenes jiribenes approved these changes

@phischu phischu Awaiting requested review from phischu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-studios @jiribenes