-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache sbt files in CI, update versions of CI actions #560
Conversation
.github/workflows/ci.yml
Outdated
uses: actions/setup-java@v1 | ||
uses: actions/setup-java@v3 | ||
with: | ||
java-version: 11 | ||
distribution: 'zulu' | ||
cache: 'sbt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newer setup-java
action requires an explicit JDK distribution. I set it to zulu
since that's what it used implicitly, but I'm open to using a different distribution. (I honestly have no idea which distribution is the best here.)
Here's the list of supported distributions https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions
It's very difficult to measure if this helps at all, I'm guesstimating based on only 5 runs. Regarding what could be done next:
|
09f42cf
to
df3aaf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Investigating #428 since I noticed that
setup-java
allows simplesbt
caching when playing with #538 :)