Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent naming scheme for output files #498

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Use consistent naming scheme for output files #498

merged 1 commit into from
Jun 12, 2024

Conversation

marvinborner
Copy link
Member

This PR closes issue #471 by only using the file basename without extension for its output path.

jiribenes
jiribenes approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had to double-check that "foo".split('/').last returns "foo" :)

@b-studios b-studios merged commit 3e38409 into master Jun 12, 2024
2 checks passed
@b-studios b-studios deleted the fix/inconsistent_filenames branch June 12, 2024 09:28
@dvdvgt dvdvgt mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiribenes jiribenes jiribenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinborner @jiribenes @b-studios