Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow new-style on[E].result Result reification #479

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Allow new-style on[E].result Result reification #479

merged 1 commit into from
Jun 4, 2024

Conversation

marzipankaiser
Copy link
Contributor

@marzipankaiser marzipankaiser commented Jun 4, 2024 •
edited by jiribenes
Loading

We introduced a new style of handling exceptions using on[E]-proxy objects.
This was not introduced for Result, but only for Option.

With this PR, we now also allow code like:

    with on[MyException].result
    // ...

jiribenes
jiribenes approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@jiribenes jiribenes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:
(Would be nice to add a test / example for this though...)

@marzipankaiser
Copy link
Contributor Author

Delaying tests to another PR, since they are also missing for the other variants (only on[...].default occurs in the string tests).

@marzipankaiser marzipankaiser merged commit ac7411d into master Jun 4, 2024
2 checks passed
@marzipankaiser marzipankaiser deleted the feature/on-exception-result branch June 4, 2024 11:37
@marzipankaiser marzipankaiser mentioned this pull request Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiribenes jiribenes jiribenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marzipankaiser @jiribenes