Fix ANSI highlighting of strings within multiline strings #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you write strings within multiline strings, the ANSI highlighting (e.g. in errors) gets escaped and rendered as if not a string at all. This annoyed me while trying to break unicode support :)
An example which induces an arbitrary error to generate wrong highlighting:
Not sure about the fix. Quotes shouldn't appear in normal strings after parsing anyway, so I believe we can just ignore them completely.
Other fixes wouldn't be straightforward since multiline strings are generally handled the same as normal strings.