LLVM Strings (UTF-8-interpreted byte buffers)
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we decided not to grow strings and need a reference count, the buffer representation will have to be changed drastically. NOTE: This comment box marks the tip of |
jfrech
force-pushed
the
feature/llvm-strings
branch
from
07b9324
to
c151751
Compare
|
|
jfrech
changed the title
Strings (UTF-8-interpreted byte buffers)
jfrech
force-pushed
the
feature/llvm-strings
branch
from
2ee8ae4
to
2d234fb
Compare
|
My recent force push should only have introduced |
|
I will wait for this merge to complete before starting a new branch where |
jfrech
force-pushed
the
feature/llvm-strings
branch
from
f50fef0
to
e919dd0
Compare
b-studios
reviewed
Sep 25, 2022
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
effekt/shared/src/main/scala/effekt/machine/PrettyPrinter.scala
Outdated
Show resolved
Hide resolved
phischu
requested changes
Sep 26, 2022
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
phischu
reviewed
Sep 26, 2022
effekt/shared/src/main/scala/effekt/generator/llvm/Transformer.scala
Outdated
Show resolved
Hide resolved
jfrech
force-pushed
the
feature/llvm-strings
branch
2 times, most recently
from
3fed1f2
to
a07065b
Compare
Valgrind reports no leaks on both `out/hello-world` and `out/strings-refcount`.
I think Effekt's string literals are buggy: "\n" is not being interpreted. Furthermore, I think our test driver meddles with newlines.
This patch is planned to later be re-instantiated on another branch.
Co-authored-by: Jonathan <jonathan@b-studios.de>
Previously, the reference count was left of the buffer's bytes. This did have the advantage that `struct Pos.obj` was the data pointer, but one had to shift for freeing.
phischu
force-pushed
the
feature/llvm-strings
branch
from
228344e
to
ced412a
Compare
phischu
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
Stringss to the LLVM backend.All strings are UTF-8 encoded;
stdout-specific encodings are not respected.