use IPv6 DNS Servers #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a domain has 2 public nameservers, lets say ns1.domain.example and ns2.domain.example, the hook now requests A and AAAA records for NS entries. These are saved to a list [ [ 'IPv4#1 of ns1', 'IPv4#2 of ns1', 'IPv6#1 of ns1'], [ 'IPv4#1 of ns2', 'IPv4#2 of ns2', 'IPv6#1 of ns2'], ] When checking the TXT-record dnspython can check any IP of this server.
ukleinek
reviewed
Jun 26, 2018
| nsL = [] | ||
| nsL.extend([_.to_text() for _ in dns.resolver.query(ns)]) # default type: A | ||
| nsL.extend([_.to_text() for _ in dns.resolver.query(ns, rdtype=dns.rdatatype.AAAA)]) | ||
| nameservers.append(nsL) |
There was a problem hiding this comment.
this could be written more easily and probably with shorter execution time as:
ns = rdata.target.to_unicode()
nsL = [_.to_text() for _ in chain(dns.resolver.query(ns),
dns.resolver.query(ns, rdtype=dns.rdatatype.AAAA))]
nameservers.append(nsL)
There was a problem hiding this comment.
Yes, you could do that, but in case you run in a 30s timeout, you have no clue, where this comes from. I personally do not like lines that does multiple things and leave you in the dark if something goes wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a domain has 2 public nameservers, lets say ns1.domain.example
and ns2.domain.example, the hook now requests A and AAAA records for NS entries.
These are saved to a list
When checking the TXT-record dnspython can check any IP of this server.