use '+' as option-prefix in sub-commands, as tokens might start with "-" #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently, tokens must only use the base64url alphabet, which means they can contain (and even start with) "-", but "+" and "/" are forbidden. we cannot tell dehydrated to insert "--" after the cmd. luckily the only option is "--help", so this shouldn't affect any scripts...
|
btw, i was just hit by this, as one of my servers couldn't deploy its challenges any more. |
|
and this is obviously a fix for #18 (which i wasn't aware of, i probably should susbcribe to the project) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently, tokens must only use the base64url alphabet, which means they
can contain (and even start with) "-", but "+" and "/" are forbidden.
we cannot tell dehydrated to insert "--" after the cmd.
luckily the only option is "--help", so this shouldn't affect any scripts...