Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiled models - ValueComparer/ValueConverter #98

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Compiled models - ValueComparer/ValueConverter #98

merged 3 commits into from
Feb 8, 2024

Conversation

lorcQc
Copy link
Collaborator

@lorcQc lorcQc commented Jan 28, 2024

No description provided.

@lorcQc lorcQc marked this pull request as draft January 28, 2024 19:36
@lorcQc
Copy link
Collaborator Author

lorcQc commented Jan 30, 2024

For the moment, the code generated for TypeMapping does not compile.

I can't use CoreTypeMapping.Clone() method as C# version does because VB can't call overridable (virual) methods when they contain a parameter with an "in" modifier. 😞

I'll see if I can do it otherwise (using public constructors perhaps). At worst, I could use reflection (MethodInfo.Invoke)...

@lorcQc lorcQc marked this pull request as ready for review February 7, 2024 03:28
@lorcQc lorcQc merged commit 93be00b into efcore:master Feb 8, 2024
1 check passed
@lorcQc lorcQc deleted the Dev_v8 branch February 8, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lorcQc