Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: quit on hold violations on all corners #587

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

feat!: quit on hold violations on all corners #587

wants to merge 8 commits into from

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Oct 17, 2024 •
edited
Loading

Steps

  • Checker.HoldViolations

    • Change default value of HOLD_VIOLATION_CORNERS to ['*'] causing error
      on hold violations on all corners

Depends on efabless/openlane2-ci-designs#35
BREAKING CHANGE: Designs with hold violations on other corners than *tt* will now need updating

@kareefardi
bugfix: fix wrong reported value for timing__*_r2r__ws__corner
73ffc69 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi
Merge branch 'worst-slack' into error-on-hold
13978af
@kareefardi
feat: error on all hold violating corners
7bf6bb8 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi kareefardi changed the base branch from main to dev October 17, 2024 09:34
@openlane-bot
Copy link
Collaborator

openlane-bot commented Oct 17, 2024 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • Changes to critical metrics were detected in the following designs:
    • gf180mcuD/gf180mcu_fd_sc_mcu7t5v0/usb_cdc_core
    • sky130A/sky130_fd_sc_hd/MS_SPI_XIP_CACHE

Full tables ► https://gist.github.com/openlane-bot/18c8b542feb0bfa93aafc45c0bc9a726

@kareefardi
update designs to fix hold violations
4744259 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi
Merge branch 'dev' into error-on-hold
7c4648b 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi
update changelog
7c0a979 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi kareefardi changed the title Error on hold feat!: quit on hold violations on all corners Oct 21, 2024
@kareefardi kareefardi marked this pull request as ready for review October 21, 2024 07:04
@kareefardi kareefardi requested a review from donn October 21, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn Awaiting requested review from donn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kareefardi @openlane-bot