Fixes to get sanpera working on windows and python 3.4 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC can't link to private methods of ImageMagick since they aren't available, sanpera doesn't use them, it looks like they were only included for completeness. MSVC can't handle many C99 features including static inside brackets, these now produce warnings, but it doesn't seem to break anything.
…ike the standard library does. This is a fairly common idiom now. I left the TODO note in since it's still debatable.
…ilename. Maybe want to add this to backports list setup.py instead of checking for it's existence, but it's not critical, so I like this solution. Alternately use try/except NameError instead of global HAS_PATHLIB variable.
Assuming that when colorspace is set, the user intended to transform the image to use that colorspace, not reinterpret the image with the new colorspace. (alternately use a transform_colorspace method to transform w/ colorspace.__set__ just setting)
… from `future` Adds a dependency on future w/o using all of futures real fanciness which I like, but upstream may not like it.
…lative imports. That seems silly to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there anything interesting in the wand branch btw? I haven't tried to merge it.
Anyway I got sanpera working on windows with python 3.4, haven't tested 2.7, but it should work, its's mostly a bunch of small changes. Have not tried 64-bit python.
There's some C99 syntax that MSVC doesn't like (that I don't fully understand either, but it doesn't seem like it breaks anything, I'm sure you used
staticfor a reason though.). Some symbols that aren't public in the windows DLLs (but aren't used for anything by sanpera, I don't think)demo-program.py updated to use the print function and remove extraneous parentheses and commas.
Also autodetect ImageMagick paths based on registry keys.
Finally, sanpera's pretty cool. I was almost ready to switch back to
wandbefore I got this working.