easier extending custom collections

[isaacs]

Fix: #457

Still todo:

• tests for custom collection tags
• update docs with examples of extending YAMLMap and YAMLSeq
• catch the error when you have a tag object that specifies collection: 'seq' but gets a map token, and vice versa. (In that case, I imagine it should raise a warning and fall back to YAMLMap or YAMLSeq as appropriate?)

[eemeli]

I like this, but there are a couple of places where I'm concerned about introducing breaking changes, in particular dropping the createNode values from the map and seq collection tags. Could those be avoided?

[isaacs]

Sure, I can put those methods back. They could just call into Class.from() I guess?

[eemeli]

Sure, I can put those methods back. They could just call into Class.from() I guess?

Yeah, that should work.

[isaacs]

Ok, pushed with updates noted. Also reworded commits to conform with the semantic-commit style here. PTAL, thanks :)

[isaacs]

Updated with the comments above.

[isaacs]

Looks like test failure is due to lacking auth secrets.

[eemeli]

I fixed the remaining lint errors on your branch; it was easier that way.

Having tested this locally, it looks good! I'm pretty sure we've managed to get rid of the breaking changes. The types docs will need some iterating, but that's really a separate change.

There's one inline fix below that's hopefully the last before this can be merged.

[eemeli]

🎉 This is now included in v2.3.0-5, available on npm as yaml@next.

I think I'll let this stay in prerelease for a week or two still before releasing v2.3.0, in case any issues are found with either the TS changes or this. Would be good to get a proper yaml-types release out for that and update the docs on custom tags/types.

[isaacs]

Cool, I'll play with it tonight, and see if I can send a or to add all of tap-yaml's types to yaml-types. Hopefully can put that repo to bed once and for all :)