Add tests & fixes for test262 compliance #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The browser tests will actually need to get added after this, because they'll also depend on applying changes to the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
It seemed like a decent time to take another shot at this, and using the harness was decently easy this time. Also fixing the issues that the tests identified was pretty straightforward.
Before merging this, I should set up some basic browser tests, as even IE 11 should still be supported.
As side effects, jest gets updated to 29, and CI tests no longer target Node.js 12.
The cross-realm tests are skipped for now, as I don't think they can be fixed for a polyfill? Happy to be proven wrong, of course.