Repository navigation
Debug library - #9
Merged
Merged
Conversation
…ix None return - datacopy/datamove: replace datacopy's mode="create"/"replace" with a unified overwrite=False (default) on both. When false, raises if the (possibly folder-adjusted) target already exists rather than letting a bare CTAS fail with Dremio's own less specific error. When true, detects the existing target's real kind (it might be a view, not a table, from an earlier different operation) and drops it with the matching verb before creating. - datamove now verifies target_path actually exists after CREATE/DROP before declaring success, rather than trusting the executor's silence — Arrow Flight SQL's completion semantics for a no-result- rows DDL statement aren't verified against this project's real deployment. - Fix datamove() returning None: verify_target_exists (the last action in the chain) now hands back the CREATE's real SqlResult instead of its own implicit None, which _run_actions was returning verbatim. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
createfolder(path, create_parents=False) raises if the parent is missing rather than creating a deep new path; create_parents=True creates every missing level (ensure_folder_path). deletefolder(path, cascade=False) raises if the folder still has contents; cascade=True deletes every table/view and subfolder inside first, depth-first, straight through the catalog-by-id REST endpoint (no SQL DROP needed). Both are idempotent (already-there/already-gone is not an error). Renames CatalogRestClient._create_folder to the now-public create_folder, and adds delete_folder with its own child-walking cascade logic (assumptions flagged as unverified, same as the rest of this module's REST layer). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.