Repository navigation
Release to staging: honor DDS's upload_mode "proxy" hint in FolderIngest (ref #306834) - #83
Merged
Merged
Conversation
- BeginResult reads upload_mode from the begin response (top level, or inside s3). - FolderIngest(upload_mode="auto"): when begin says "proxy", every file is sent whole through POST /api/v1/ingest/stage (session_id + rel_path form fields, file part) instead of the presigned S3 targets, so the client never connects to the storage itself (avoids the client-side TLS hostname mismatch). "proxy" forces it, "direct" keeps presigned uploads. - IngestOutcome.upload_mode says which path was used; commit gets no S3 ETags in proxy mode. - Tests for the hint, the overrides and the /stage request shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Redmine-Hook: v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developmenttostaging. Ref #306834.What's in it
BeginResult.upload_modereads the server's hint from thebeginresponse, at the top level or insides3.FolderIngest(..., upload_mode="auto"): whenbeginsays"proxy", every file is sent whole throughPOST /api/v1/ingest/stage(form fieldssession_idandrel_path, plus afilepart) instead of the presigned S3 targets.CERTIFICATE_VERIFY_FAILED: Hostname mismatchagainstsggw.pdmz.eea."proxy"forces this path, and"direct"keeps the presigned uploads.IngestOutcome.upload_modesays which path was used. In proxy mode,commitgets no S3 ETags.Tests
566 passed, 1 skipped. New tests cover the hint, the overrides and the
/stagerequest shape. Not yet run against the real DDS.🤖 Generated with Claude Code