fix: correct notifications anchor link for tutor settings url #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais-ansari
approved these changes
May 14, 2025
|
@Abdul-Muqadim-Arbisoft, please update the commit message. The code is looking good to me. |
Abdul-Muqadim-Arbisoft
changed the title
Abdul-Muqadim-Arbisoft
changed the title
Abdul-Muqadim-Arbisoft
force-pushed
the
fix/account-settings-url-suffix
branch
from
a282815 to
f155997
Compare
Abdul-Muqadim-Arbisoft
force-pushed
the
fix/account-settings-url-suffix
branch
from
f155997 to
44ba3b9
Compare
muhammadadeeltajamul
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in Tutor-based installations where the ACCOUNT_SETTINGS_URL contain a trailing slash. The destination link to
#notificationsnow conditionally adds a slash only when necessary, preventing malformed URLs.