feat!: upgrade to Paragon v23 and design tokens #6
Conversation
Pull Request Test Coverage Report for Build 15714850646Details
💛 - Coveralls |
There was a problem hiding this comment.
NOTE: All of the code comments below are copy/pasted from https://github.com/edx/frontend-plugin-advertisements/pull/93/files
| "@edx/frontend-component-footer": "14.7.1", | ||
| "@edx/frontend-component-header": "6.4.0", | ||
| "@edx/frontend-platform": "8.3.5", | ||
| "@openedx/paragon": "^22.17.0", | ||
| "@openedx/paragon": "^23.0.0", |
There was a problem hiding this comment.
🚨 [inform] Breaking change! Drops support for v22.
| @@ -27,11 +27,10 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@cospired/i18n-iso-languages": "^2.0.2", | |||
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", | |||
There was a problem hiding this comment.
[inform] @edx/brand is not directly used within this project (no imports, etc.), so we're opting to remove it from these dependencies.
| @import "~@edx/brand/paragon/fonts"; | ||
| @import "~@edx/brand/paragon/variables"; | ||
| @import "~@openedx/paragon/scss/core/core"; | ||
| @import "~@edx/brand/paragon/overrides"; |
There was a problem hiding this comment.
[inform] Previously would re-import all of Paragon's styles as duplicate CSS on top of the Paragon CSS already downloaded/used by the MFE itself. Rather than this import, ideally this package would have imported this stylesheet into the package's styles entrypoint vs. re-importing all of Paragon just to make SCSS variables work.
Either way, with Paragon v23 and CSS variables, these custom styles no longer use SCSS variables/functions so this import should be removed.
https://2u-internal.atlassian.net/wiki/spaces/FEDX/pages/2059829538/Upgrade+MFEs+to+Paragon+v23+with+edx+elm-theme+CSS+variables+via+design+tokens#:check_mark:-@edx/frontend-plugin-persona