feat: upgrade react to v18 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Pull Request Test Coverage Report for Build 14857311678Details
💛 - Coveralls |
| </AppProvider>, | ||
| document.getElementById('root'), | ||
| rootNode.render( | ||
| <StrictMode> |
Member
There was a problem hiding this comment.
This looks good overall. I'm curious about the StrictMode component. Could you help me understand what it is and why it's necessary for the upgrade?
Author
There was a problem hiding this comment.
Hey @michaelroytman, this is mentioned here in the roadmap.
michaelroytman
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades react to v18 under this epic.