feat: integrate platform verification attempt #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/integrate_platform_attempt_id
branch
from
48b1c33
to
b1e2cb8
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
schenedx
approved these changes
Sep 23, 2024
edx_name_affirmation/api.py
Outdated
| @@ -194,23 +146,29 @@ def update_verified_name_status( | |||
| * status (Verified Name Status) | |||
| * verification_attempt_id (int) | |||
| * proctored_exam_attempt_id (int) | |||
| * platform_verification_attempt_id (int) | |||
There was a problem hiding this comment.
Could we please update the comments here? I feel like with the platform_verification_attempt_id, the comments, should be more specific about how it should work with verification_attempt_id
| verification_attempt_id=verification_attempt_id, | ||
| proctored_exam_attempt_id=proctored_exam_attempt_id, | ||
| ) | ||
| if sum(map(bool, [proctored_exam_attempt_id, verification_attempt_id, platform_verification_attempt_id])) > 1: |
There was a problem hiding this comment.
Can't we just choose one instead of raising error? Should we favor the platform_verification_attempt_id? I am afraid if we run into this conflict condition, the user will see blocking errors and cannot continue.
There was a problem hiding this comment.
I think that is a fair point, although it would introduce a change in behavior. I'll ask in stand up!
alangsto
force-pushed
the
alangsto/integrate_platform_attempt_id
branch
from
b1e2cb8
to
788fc69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR integrates the newly added
platform_verification_attempt_idfield into the name affirmation code.JIRA:
COSMO-495
Pre-Merge Checklist:
edx_name_affirmation/__init__.pyif these changes are to be released. See OEP-47: Semantic Versioning.CHANGELOG.rst.Post-Merge: