Skip to content

fix: improve ct call in program price api #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

syedsajjadkazmii
Copy link
Contributor

Fix errors and put retries on CT calls in program price api view

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

Copy link

github-actions bot commented Apr 11, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools
  http_api_client.py 158
  commerce_coordinator/apps/commercetools/tests
  test_http_api_client.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/retry-ct-call branch 3 times, most recently from 0869230 to 4a61bd0 Compare April 11, 2025 12:07
@syedsajjadkazmii syedsajjadkazmii merged commit 068b39e into main Apr 11, 2025
8 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/retry-ct-call branch April 11, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants