Skip to content

fix: fix log stream issue locally #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

mubbsharanwar
Copy link
Contributor

@mubbsharanwar mubbsharanwar commented Mar 20, 2025

We are moving the logging format string to the remote config to fix the logging issue locally.

We can set LOGGING_FORMAT_STRING in our private.py file to get logs for local env like:

LOGGING_FORMAT_STRING = '%(asctime)s %(levelname)s %(process)d [%(name)s] [user %(userid)s] [ip %(remoteip)s] %(filename)s:%(lineno)d - %(message)s'

edx-internal

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

Copy link

github-actions bot commented Mar 20, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@mubbsharanwar mubbsharanwar force-pushed the manwar/locally-logging-issue-fix branch from 28d3963 to 9ba5ada Compare March 28, 2025 05:00
@mubbsharanwar mubbsharanwar force-pushed the manwar/locally-logging-issue-fix branch 5 times, most recently from c077ce9 to bbc250b Compare April 3, 2025 10:42
@mubbsharanwar mubbsharanwar force-pushed the manwar/locally-logging-issue-fix branch from bbc250b to 9b56d54 Compare April 21, 2025 07:43
@abdullahwaheed abdullahwaheed merged commit bd5cabd into main Apr 24, 2025
8 checks passed
@abdullahwaheed abdullahwaheed deleted the manwar/locally-logging-issue-fix branch April 24, 2025 12:24
syedsajjadkazmii pushed a commit that referenced this pull request Apr 25, 2025
* fix: fix log stream issue locally

* fix: address review comments

---------

Co-authored-by: Muhammad Abdullah Waheed <abdullah.waheed@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants