[BD-46] refactor: refactoring buttons variants #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat. |
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/buttons-variants
branch
from
a62b295
to
c0a3227
Compare
monteri
approved these changes
Jul 27, 2023
|
[inform] Note: the failing |
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/buttons-variants
branch
from
d476ccf
to
176a3da
Compare
10 tasks
| @@ -2,7 +2,7 @@ | |||
| "elevation": { | |||
| "image": { | |||
| "thumbnail": { | |||
| "box-shadow": { "value": "none" } | |||
| "box-shadow": { "value": "0 1px 2px rgba(0, 0, 0, .075)" } | |||
There was a problem hiding this comment.
[clarification] Looking at the Image component using the edX.org theme on the Paragon docs site for master, it looks like the Image thumbnail doesn't have a box-shadow?
There was a problem hiding this comment.
Yes you are right
This pull request will be closed, and a new one with corrections will be opened here
… (edx#59) Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com>
* fix: upgrade paragon * fix: delete dist folder
* fix: add empty .npmignore to ensure dist folder gets published * chore: ci workflow * chore: rename ci job * chore: rename ci job * chore: build design tokens
* feat: compile source tokens only * fix: upgrade to paragon-alpha.34
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/buttons-variants
branch
from
0346215
to
58d616a
Compare
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/buttons-variants
branch
from
58d616a
to
a8e7196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: openedx/paragon#2389