Skip to content
This repository was archived by the owner on Sep 28, 2024. It is now read-only.

Refactorization and cleanup #815

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c773d81
Refactored to follow Kotlin Coding Conventions (https://kotlinlang.or…
SackCastellon Sep 9, 2018
98d3758
Refactored to follow Kotlin Coding Conventions.
SackCastellon Sep 13, 2018
bbe5fe6
Added return type to all public functions to ensure API stability.
SackCastellon Sep 13, 2018
701154c
Refactored to follow Kotlin Coding Conventions.
SackCastellon Sep 14, 2018
f11bc50
Rewritten tests in a more idiomatic way.
SackCastellon Sep 18, 2018
707e325
Merge branch 'master' of https://github.com/edvin/tornadofx into refa…
SackCastellon Sep 18, 2018
333d30f
Sorted and grouped functions based on functionality.
SackCastellon Sep 18, 2018
b9770d2
Fixed formatting, simplified assertion on list and removed unused code.
SackCastellon Sep 18, 2018
a9c2b5c
Refactored to follow Kotlin Coding Conventions.
SackCastellon Sep 25, 2018
3a26146
Fixed some comments
SackCastellon Sep 25, 2018
c3d6d7a
Forgot to update AsyncTest 😅
SackCastellon Sep 25, 2018
73511a6
Refactored to follow Kotlin Coding Conventions.
SackCastellon Sep 27, 2018
7352656
Refactored to follow Kotlin Coding Conventions.
SackCastellon Sep 28, 2018
d4759e7
Kotlin Coding Conventions.
SackCastellon Sep 30, 2018
a331b90
Merge branch 'master' of https://github.com/edvin/tornadofx into refa…
SackCastellon Sep 30, 2018
0c4fc3e
Removed some unnecesary `inline` modifiers.
SackCastellon Sep 30, 2018
0c5035f
Added return type to ensure API stability.
SackCastellon Sep 30, 2018
2cf487f
Refactorization and cleanup
SackCastellon Sep 30, 2018
b64a241
Added return types to ensure API stability.
SackCastellon Oct 1, 2018
da2ef5a
Simplified code to choose where to run `fireEvents()` in `EventBus.fi…
SackCastellon Oct 1, 2018
f108483
Refactored to follow Kotlin Coding Conventions.
SackCastellon Oct 4, 2018
4c101eb
Merge remote-tracking branch 'upstream/master' into refactorization-a…
SackCastellon Oct 4, 2018
b958664
Merge remote-tracking branch 'upstream/master' into refactorization-a…
SackCastellon Oct 6, 2018
ec12e78
Updated code based on feedback.
SackCastellon Oct 10, 2018
702620a
Simplified `App` constructors
SackCastellon Oct 10, 2018
6284298
Merge remote-tracking branch 'upstream/master' into refactorization-a…
SackCastellon Oct 17, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@
- `DefaultScope` deprecated, use `FX.defaultScope` instead
- The Workspace inside the `scope` of a UIComponents will assume the Workspace it is docked in (https://github.com/edvin/tornadofx/issues/806)
- Kotlin 1.2.70
- Refactored code to follow Kotlin Coding Conventions.
- Specified public & protected declaration types explicitly to ensure API stability.
- Simplified some code by using Kotlin idioms, and replaced direct platform call with extension functions.
- Fixed endless recursive function call. (See Animation.kt:L512)
- Added `inline` modifier to `runLater` top level functions and `crossinline` to `op` parameter. (See Async.kt:L142 & Async.kt:L155)
- Replaced `Latch.lockedProperty()` function with a property with a custom getter, and renamed private property `Latch.lockedProperty` to `Latch._lockedProperty`.
- Unified all the style class related functions from `Nodes.kt` and `CSS.kt`, also improved to avoid adding duplicates.
- Fixed recursive loop in `JsonObject.float()`.
- Added support for some missing types when creating a JsonArray, also when an unsupported type is found a warning is logged. (See Json.kt:L215-L239)
- Added missing function `TreeTableView<S>.column(String, KClass<T>, TreeTableColumn<S, T>.() -> Unit)` to be consistent with existing `column()` functions.

### Additions

Expand All @@ -20,6 +30,9 @@
- Media.play() shortcut which creates a MediaPlayer and plays the Media
- Wipe and Dissolve view transitions
- `tab` builder assigns `UIComponent.icon` as Tab graphic
- Added `toggleClass` variant with `Iterable<Styleable>` as receiver and `ObservableValue<Boolean>` as predicate.
- Added `TreeTableView<T>.onUserDelete()` function.
- Added missing BigInteger getters from a JsonObject.

## [1.7.17]

Expand Down
5 changes: 2 additions & 3 deletions src/main/java/sun/net/www/protocol/css/Handler.kt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ open class Handler : URLStreamHandler() {
override fun openConnection(url: URL): URLConnection = CSSURLConnection(url)

class CSSURLConnection(url: URL) : URLConnection(url) {
override fun connect() { }
override fun connect() {}
override fun getInputStream(): InputStream {
if (url.port == 64) return Base64.getDecoder().decode(url.host).inputStream()
val stylesheet = Class.forName(url.host).newInstance() as Stylesheet
Expand All @@ -25,7 +25,6 @@ open class Handler : URLStreamHandler() {
}

class HandlerFactory : URLStreamHandlerFactory {
override fun createURLStreamHandler(protocol: String) =
if ("css" == protocol) Handler() else null
override fun createURLStreamHandler(protocol: String): Handler? = if ("css" == protocol) Handler() else null
}
}
Loading