Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added abstract 'columns' property to table #6

Merged
merged 3 commits into from
Aug 11, 2017

Conversation

PvdBerg1998
Copy link
Contributor

No description provided.

@edvin
Copy link
Owner

edvin commented Aug 11, 2017

This isn't a good solution to the reflection problem because it adds boilerplate. A better approach would be to have definitions themselves actually add the columns to the columns list. Then we could keep the columns list internal as well.

@PvdBerg1998
Copy link
Contributor Author

I'd still prefer more boilerplate over reflection, but if there is a cleaner way ... I'm trying to add the column to a list inside of the Table.column function, but I can't figure out how to get the instance out of the delegate.

@edvin
Copy link
Owner

edvin commented Aug 11, 2017

You can, but unfortunately not until the property is accessed. Therefor I think we need to skip the delegate and use a function instead.

@edvin
Copy link
Owner

edvin commented Aug 11, 2017

Great! This is the right move!

@edvin edvin merged commit d2be528 into edvin:master Aug 11, 2017
@PvdBerg1998 PvdBerg1998 deleted the columns branch August 12, 2017 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants