chore: merge develop into staging #1426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix critical build error in EmailEditor.tsx (missing useTranslation import) - Remove unnecessary useCallback dependencies in CreatableDropDown.tsx - Remove unused imports and variables across multiple components - Wrap formatTimeValue in useCallback to fix dependency warning in TimePicker.tsx - Clean up unused mutations and imports in ExpandableCourseRow.tsx - Fix unused parameter warnings in ApiKeyManager.tsx and errorHandling.ts All files now pass linting with no warnings and build completes successfully.
https://github.com/eduhub-org/eduhub into issue1392/FEATURE-new-add-improved-location-addresses
- Update docker-compose.yml to fix hot reload and real-time updates in dev mode
- Fix mobile-responsive-design.mdc configuration
- Add defaultSessionAddressId to CourseLocation table - Create migration to migrate existing default session addresses to location addresses - Update frontend components to use new location address system - Add new GraphQL queries and mutations for location address management - Update translations for new location address functionality - Add migration summary documentation - Update course content management with improved address handling
- Add ReactMarkdown and remarkGfm imports to FaqSection component - Replace plain text rendering with ReactMarkdown component - Add prose styling classes for consistent markdown formatting - Maintain backward compatibility with existing plain text FAQs - Enable rich formatting: bold, italic, lists, links, code blocks, tables
- Enhance permission checks for CourseLocation metadata - Add proper foreign key constraints and indexes to migrations - Improve migration rollback handling with proper error messages - Fix English translation capitalization for 'Default' label
- Update CourseLocation metadata configuration - Enhance ManageAppSettingsContent component - Improve ManageCoursesContent and ExpandableCourseRow components - Update GraphQL queries and generated types for course location handling - Refactor course group options and course list queries
- Update code to use 'sessionAddress.default_address' instead of 'sessionAddress.default' - Ensures consistency between code and translation files - Fixes missing translation key issue reported by reviewer
… access - Add admin role permissions to LocationAddress table in Hasura metadata - Admin can now access SessionAddresses_aggregate and CourseLocations_aggregate - Admin has full CRUD permissions with locationOption update capability - Update ManageLocationAddressesContent to use useAdminQuery/useAdminMutation - Add admin role check to location addresses management page - Add AuthErrorContext for better authentication error handling - Rename locationOptionId to locationOption across schema - Fix validation trigger column references in migrations - Add tests for Sessions component Fixes authentication error: "field 'SessionAddresses_aggregate' not found in type: 'LocationAddress'" when admin users reload the location addresses management page.
… table - Add filter to exclude ONLINE location option from table query - Remove ONLINE option from location dropdown selector - Update column header from 'Address / Link' to 'Address' - Simplify address input field to only handle physical addresses - Update translations: 'Standort / Online' -> 'Standort' (DE), 'Location Option' -> 'Location' (EN)
…rganizations tables - Enable column sorting for location addresses table (shortLabel, address, locationOption, usageCount) - Enable column sorting for organizations table (name, userCount) - Add configurable page size selection to organizations table - Improve data exploration and navigation in admin management interfaces
…Content Remove unnecessary useAdminQuery(LOCATION_ADDRESS_LIST) call from ExpandableLocationAddressRow component. The query is already handled by useTableGrid hook, and mutations trigger refetchQueries to keep data in sync.
…vements chore: Fix/location addresses improvements
github-actions
bot
added
the
auto-updated
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ication statistics - Add checkbox to toggle between calendar dates and days-until-application-end on x-axis - Default to days-until-application-end view for better comparison across programs - Update GraphQL query to include defaultApplicationEnd field - Implement proper cumulative chart logic that never decreases - Fill gaps with zeros to show all days in range without missing data - Sort program dropdown by applicationStart date (most recent first) - Update German translation: 'Nutze das Kalender-Datum auf der X-Achse' - Update English translation: 'Use Calendar Date on X-Axis' The new view allows comparing application patterns across different programs by showing how many days before the deadline applications were submitted.
…istration-statistics-to-a-common-endpoint feat(statistics): add days-until-application-end x-axis mode for appl…
…onStatistics Add nullish coalescing operator to ensure array methods are called on a safe array fallback, preventing crashes during query loading state.
…dd missing translation - Increase maxOtherPrograms from 3 to 6 to show last 6 semesters - Add 'all_programs' translation key in German (Alle) and English (All) - Update 'All' tab to use translation instead of hardcoded string - Add translation dependency to useMemo for proper reactivity
- Add checkboxes and bulk action support to DegreeParticipationsTab - Implement 'Generate Achievement Certificates' bulk action - Implement 'Delete Achievement Certificates' bulk action - Create REMOVE_ACHIEVEMENT_CERTIFICATES GraphQL mutation - Migrate column sizing from legacy meta.width to modern size properties - Add user feedback via NotificationSnackbar for success/error states - Add translations for bulk actions (DE/EN) Breaking changes: None Closes: N/A
…oss roles - Add created_at column to instructor_access and user_access permissions - Improve client-side record selection using explicit sort instead of reduce - Remove debug console.log statements for cleaner code - Ensures instructors and admins see the same achievement record status When multiple achievement records exist for a user, the frontend now consistently selects the most recent record based on created_at timestamp using deterministic sorting, regardless of user role.
- Remove admin role from insert_permissions - Remove admin role from select_permissions - Remove admin role from update_permissions - Remove admin role from delete_permissions Admin role has automatic full access in Hasura, explicit permissions cause metadata inconsistencies
…changes docker-compose accordingly
…ainer-stopping Added Dockerfile to python functions to fix issue with xhtml2pdf and …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.