eduherminio · eduherminio · Dec 2, 2023 · Dec 2, 2023 · Dec 2, 2023 · Dec 2, 2023
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -2,7 +2,7 @@ version: 2.1
 executors:
   fileparser-executor:
     docker:
-      - image: mcr.microsoft.com/dotnet/sdk:6.0
+      - image: mcr.microsoft.com/dotnet/sdk:8.0
     working_directory: ~/FileParser
 
 jobs:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,7 +28,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 6.0.x
+        dotnet-version: 8.0.x
 
     - name: Setup .NET 5 for sonar
       if: matrix.os == 'windows-latest'
@@ -40,7 +40,7 @@ jobs:
       uses: actions/setup-java@v4
       if: matrix.os == 'windows-latest'
       with:
-        java-version: 11
+        java-version: 17
         distribution: 'zulu'
 
     - name: '[Windows] Cache SonarCloud packages'

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -51,7 +51,7 @@ jobs:
     - name: Setup .NET Core
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 6.0.x
+        dotnet-version: 8.0.x
 
     - name: Set version to ${{ github.event.inputs.new_package_version }}
       shell: pwsh

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,7 +1,6 @@
 <Project>
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
     <LangVersion>latest</LangVersion>
     <Nullable>Enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -9,7 +9,7 @@ schedules:
     - main
 
 variables:
-  SdkVersion: '6.0.x'
+  SdkVersion: '8.0.x'
 
 stages:
 - stage: CI

diff --git a/src/FileParser.Benchmark/FileParser.Benchmark.csproj b/src/FileParser.Benchmark/FileParser.Benchmark.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFramework>net8.0</TargetFramework>
     <OutputType>Exe</OutputType>
   </PropertyGroup>
 

diff --git a/src/FileParser/FileParser.csproj b/src/FileParser/FileParser.csproj
@@ -1,4 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
+  </PropertyGroup>
+
   <PropertyGroup>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
@@ -17,8 +22,15 @@
     <RepositoryType>git</RepositoryType>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
 
+  <ItemGroup>
+    <None Include="..\..\README.md" Pack="true" PackagePath="">
+      <Link>Properties\README.md</Link>
+    </None>
+  </ItemGroup>
+
   <PropertyGroup>
     <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
     <NoWarn>1591</NoWarn>

diff --git a/src/FileParser/ParsingException.cs b/src/FileParser/ParsingException.cs
@@ -1,8 +1,5 @@
-using System.Runtime.Serialization;
-
-namespace FileParser
+namespace FileParser
 {
-    [Serializable]
     public class ParsingException : Exception
     {
         private const string GenericMessage = "Exception triggered during parsing process";
@@ -18,9 +15,5 @@ public ParsingException(string message) : base(message ?? GenericMessage)
         public ParsingException(string message, Exception inner) : base(message ?? GenericMessage, inner)
         {
         }
-
-        protected ParsingException(SerializationInfo info, StreamingContext context) : base(info, context)
-        {
-        }
     }
 }
diff --git a/tests/FileParser.Test/FileParser.Test.csproj b/tests/FileParser.Test/FileParser.Test.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFramework>net8.0</TargetFramework>
     <IsPackable>false</IsPackable>
   </PropertyGroup>