Skip to content

Mark static Queue<IParsedLine> ParseFile() as obsolete #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eduherminio merged 2 commits into from
Dec 2, 2023
Merged

Mark static Queue<IParsedLine> ParseFile() as obsolete #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5d7ee
Mark `static Queue<IParsedLine> ParseFile()` as obsolete
eduherminio Dec 2, 2023
a0a3efc
Merge remote-tracking branch 'origin/main' into obsolete-method
eduherminio Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/FileParser/Implementations/ParsedFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ public ParsedFile(string path, char[] existingSeparator)
/// <param name="path">FilePath</param>
/// <param name="existingSeparator">Word separator (space by default)</param>
public ParsedFile(string path, string? existingSeparator = null)
#pragma warning disable CS0618 // Type or member is obsolete - will keep it as private
: base(ParseFile(path, existingSeparator))
#pragma warning restore CS0618 // Type or member is obsolete
{
}

Expand Down Expand Up @@ -211,6 +213,7 @@ public static List<List<T>> ReadAllGroupsOfLines<T>(string path)
/// <exception cref="ArgumentException"></exception>
/// <exception cref="ArgumentNullException"></exception>
/// <returns></returns>
[Obsolete("This method exposes internal functionality and was made public accidentally. It will be removed in next major release, please used ParsedFile constructor instead.")]
public static Queue<IParsedLine> ParseFile(string path, string? existingSeparator = null)
{
Queue<IParsedLine> parsedFile = new();
Expand Down