Fixed ips for local registry and mirrors#851
Closed
jorgemoralespou wants to merge 1 commit intoeducates:developfrom
Closed
Fixed ips for local registry and mirrors#851jorgemoralespou wants to merge 1 commit intoeducates:developfrom
jorgemoralespou wants to merge 1 commit intoeducates:developfrom
Conversation
Collaborator
|
How does this sit with respect to all the CLI refactoring you are doing. Will there be conflicts with CLI refactoring if this is merged? |
Collaborator
Author
|
No. I will merge this into the cli refactoring. This is a small and controlled change. |
Collaborator
Author
|
Superseded by #871 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #850
Local registry will now get by default 172.18.200.1 (so kind network with 200.1 as offset)
Every mirror will also get a similar offset but hashed by registry name and if there's collision, will increase by 1 until available.
We have simplified how the check for port 80/443 availability on cluster creation was done
We now detect if it's a disconnected install (by checking connection to docker hub) and if not available, we set do skip-image-resolution at install time.
With these changes, you can now survive Docker Desktop restarts and also install Educates on a machine without internet connection (as long as prepopulated mirrors and docker images are already present on the system).