Skip to content

Conversation

@Srustisundar
Copy link

  1. Added strict validation for test names to ensure only simple filenames are accepted.
  2. Validated command aguments once and reused the sanitized result to avoid accidental reintroduction of untrusted input.
    3.Resolved executable paths to their canonical (real) filesystem paths before execution.
  3. Verified that the canonical path still resides within the allowed examiner directories, preventing symlink-based escapes.
  4. Added a defense-in-depth validation before process execution to make intent clear and auditable.

Why this was done
Static analysis flagged the previous implementation due to potential ambiguity around child process execution paths.
Although practical exploitation was already constrained, this hardening removes any remaining doubt by making all trust boundaries explicit also increases the veracode security score

Copy link
Collaborator

@jorgemoralespou jorgemoralespou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Srustisundar All looks fine except for the reformatting of existing code and change in formatting style. But we can fix that in a later PR, since we need to add global formatter

@jorgemoralespou
Copy link
Collaborator

@GrahamDumpleton Are you ok with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants