Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working with Minimal Mistakes Theme two days ago #183

Closed
lsolesen opened this issue Mar 19, 2018 · 3 comments
Closed

Stopped working with Minimal Mistakes Theme two days ago #183

lsolesen opened this issue Mar 19, 2018 · 3 comments

Comments

@lsolesen
Copy link

Two days ago Staticman v2 suddenly stopped working with my Minimal Mistakes Theme. I opened an issue at the theme mmistakes/minimal-mistakes#1590.

However, it might be connected to this commit 28caae6, where you two days ago introduced 'undefined'?

@mmistakes
Copy link

I'm noticing the same on my personal site which doesn't use this theme, but shares some similar logic.

Console is printing out:

Failed to load resource: the server responded with a status of 500 ()

responseText: "{"success":false,"data":["hidden"],"rawError":{"_smErrorCode":"INVALID_FIELDS","data":["hidden"]},"errorCode":"INVALID_FIELDS"}"

@mmistakes
Copy link

mmistakes commented Mar 19, 2018

Could it have anything to do with hidden fields and the introduction of undefined? On both the MM and my personal site I use a hidden input for the "honeypot" method of catching spam.

<input type="text" id="comment-form-location" name="fields[hidden]" autocomplete="off"/>

I tried the Popcorn demo and it is working fine. Apart from reCaptcha the only other thing I noticed the Popcorn demo not using was fields[hidden].

@eduardoboucas
Copy link
Owner

This is my bad, I'm sorry. I have reverted the commit that @lsolesen referenced. The intention was to fix the issue in #176, but my logic was flawed. I'll address it in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants