Make the allowFields check use undefined

eduardoboucas · Mar 17, 2018 · 28caae6 · 28caae6
1 parent 87f3115
commit 28caae6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 <img src="logo.png" width="300">
 
-# Staticman [![coverage](https://img.shields.io/badge/coverage-54%25-red.svg?style=flat?style=flat-square)](https://github.com/eduardoboucas/staticman) [![Build Status](https://travis-ci.org/eduardoboucas/staticman.svg?branch=master)](https://travis-ci.org/eduardoboucas/staticman) [![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)
+# Staticman [![coverage](https://img.shields.io/badge/coverage-53%25-red.svg?style=flat](https://github.com/eduardoboucas/staticman) [![Build Status](https://travis-ci.org/eduardoboucas/staticman.svg?branch=master)](https://travis-ci.org/eduardoboucas/staticman) [![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)
 
 > Static sites with superpowers
 

diff --git a/lib/Staticman.js b/lib/Staticman.js
@@ -388,7 +388,7 @@ Staticman.prototype._validateFields = function (fields) {
 
   Object.keys(fields).forEach(field => {
     // Check for any invalid fields
-    if ((this.siteConfig.get('allowedFields').indexOf(field) === -1) && (fields[field] !== '')) {
+    if ((this.siteConfig.get('allowedFields').indexOf(field) === -1) && (fields[field] !== undefined)) {
       invalidFields.push(field)
     }
 

diff --git a/test/utils/coverage.js b/test/utils/coverage.js
@@ -27,7 +27,7 @@ coberturaBadger(opts, function parsingResults(err, badgeStatus) {
   // open the README.md and add this url
   fs.readFile(readme, {encoding: 'utf-8'}, function (err, body) {
     body = body.replace(/(!\[coverage\]\()(.+?)(\))/g, function(whole, a, b, c) {
-      return a + badgeUrl.replace('%','%25') + '?style=flat-square' + c
+      return a + badgeUrl
     })
 
     fs.writeFile(readme, body, {encoding: 'utf-8'}, function (err) {

diff --git a/test/utils/coverage.svg b/test/utils/coverage.svg