Configure Minimum Character Length for Autocomplete in "Freigabe" and in "Workflow"

[Edmondi-Kacaj]

This update introduces the ability for administrators to specify the minimum number of characters required for autocomplete suggestions in the "Freigabe" and "Workflow" panels. With this enhancement, users will only see suggestions that match the initial characters they enter.

We aim to include this implementation in either version 8.1 or 9.0.

Identification of Dead Code

In the AuthoritySearchInputComponent, we have two sections of code:

this.suggestionGroups$ = this.input.valueChanges.pipe(
    startWith(''),
    debounceTime(500),
    filter(() => {
        if (this.input.value?.length < 2) {
            this.suggestionLoading.next(false);
            return false;
        }
        return true;
    }),
    tap(() => this.suggestionLoading.next(true)),
    switchMap((value) => this.getSuggestions(value)),
    tap(() => this.suggestionLoading.next(false)),
);

and also

getSuggestions(inputValue: string): Observable<SuggestionGroup[]> {
    if (inputValue.length < 2) {
        if (this.showRecent && this.restConnector.getCurrentLogin()?.currentScope == null) {
            return this.getRecentSuggestions();
        } else {
            return of(null);
        }
    } else {
        switch (this.mode) {
            case AuthoritySearchMode.Users:
                return this.getUsersSuggestions(inputValue);
            case AuthoritySearchMode.UsersAndGroups:
                return this.getUsersAndGroupsSuggestions(inputValue);
            case AuthoritySearchMode.Organizations:
                return this.getOrganizationsSuggestions(inputValue);
        }
    }
}

Upon review, looks like the code inside the if block in the getSuggestions

method will never be executed due to the condition in the first part of the code block.

P.S: The logic, for this pull request, has been implemented in both sections.

[Edmondi-Kacaj]

Hello @torsten-simon, any news about this pull request