issue.global_function_call

Global function call

class foo
{
    public function bar ($x) 
    {
        $x = validate($x);

        // ...
    }
}

function validate ($x)
{
    // ...
}

Why is this a testing issue?

Global function calls can't be replaced in run-time, so there's no way of testing the code in isolation.

Possible refactorings

Write the function as a method

class foo
{
    public function bar ($x) 
    {
        $x = $this->validate($x);

        // ...
    }

    public function validate ($val)
    {
        // ...
    }
}