Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translation #957

Merged
merged 4 commits into from
Mar 16, 2020
Merged

Add Spanish translation #957

merged 4 commits into from
Mar 16, 2020

Conversation

nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Feb 13, 2020

No description provided.

@nvdaes
Copy link
Contributor Author

nvdaes commented Feb 13, 2020

@danielweck : I have added the spanish translation as commented on email list.
Hope this helps. Thanks for your attention and work.

@panaC
Copy link
Member

panaC commented Feb 14, 2020

thank you very much for your PR.

Do you know how to connect the new language in the code ?
So that your PR can be integrated into thorium.

check this file : https://github.com/readium/readium-desktop/blob/develop/src/common/services/translator.ts

Otherwise we will integrate it

@nvdaes
Copy link
Contributor Author

nvdaes commented Feb 15, 2020

I modified the mentioned file. Please let me know if something needs to be added or changed. I suppose that locale-names files are automatically generated. Hope a procedure for contributing can be documented, maybe helpful :)

@nvdaes
Copy link
Contributor Author

nvdaes commented Feb 17, 2020

With my last commit, checks failed. Seems that src\resources\locale-names/esLang.json needs to be created to translate language names. In this case, I will push another commit for this, based on
http://utils.mucattu.com/iso_639-1.html
Please, let me know if this is not needed.

@panaC
Copy link
Member

panaC commented Feb 17, 2020

yes, you are right, @Scarsniik used this script to convert csv from wikipedia to json.
If that can help you. I guess these ISO codes are not easy to get.

@nvdaes
Copy link
Contributor Author

nvdaes commented Feb 17, 2020

I have followed the following criteria:

  • Capitalize initial character of language names, as done in other languages, though in Spanish is only required in certain situations.
  • Use the first or most wnown or easy name when various names can be used for the same language.
    Please, review and merge when appropiate. Thanks

@panaC
Copy link
Member

panaC commented Feb 18, 2020

perfect, thank-you. I tested it works well.

@danielweck will be able to merge if he agrees.

@nvdaes
Copy link
Contributor Author

nvdaes commented Feb 18, 2020

Thanks, if/when @danielweck merges this, I will make a post to share this with spanish users.

@danielweck danielweck changed the base branch from develop to feat/l10n/spanish March 16, 2020 23:26
@danielweck
Copy link
Member

Thank you! Merging this PR into a staging branch in order to check against the latest updates (keyboard shortcut editor new labels, etc.)

@danielweck danielweck merged commit 762a7ed into edrlab:feat/l10n/spanish Mar 16, 2020
@danielweck danielweck mentioned this pull request Mar 16, 2020
@danielweck
Copy link
Member

Follow-up PR: #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants