-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spanish translation #957
Conversation
@danielweck : I have added the spanish translation as commented on email list. |
thank you very much for your PR. Do you know how to connect the new language in the code ? check this file : https://github.com/readium/readium-desktop/blob/develop/src/common/services/translator.ts Otherwise we will integrate it |
I modified the mentioned file. Please let me know if something needs to be added or changed. I suppose that locale-names files are automatically generated. Hope a procedure for contributing can be documented, maybe helpful :) |
With my last commit, checks failed. Seems that src\resources\locale-names/esLang.json needs to be created to translate language names. In this case, I will push another commit for this, based on |
yes, you are right, @Scarsniik used this script to convert |
I have followed the following criteria:
|
perfect, thank-you. I tested it works well. @danielweck will be able to merge if he agrees. |
Thanks, if/when @danielweck merges this, I will make a post to share this with spanish users. |
Thank you! Merging this PR into a staging branch in order to check against the latest updates (keyboard shortcut editor new labels, etc.) |
Follow-up PR: #971 |
No description provided.