Dev 0.3 refactor share module #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. adapt pre-version share token 2. check token and data permission
1. adapt pre-version share token 2. check token and data permission
xxxllluuu
reviewed
Aug 17, 2020
| shareFactor.setShareEntity(dashboard); | ||
| break; | ||
| case DISPLAY: | ||
| Display display = displayService.getDisplay(shareFactor.getSharerId(), user); |
There was a problem hiding this comment.
这里应该是"displayService.getDisplay(shareFactor.getEntityId(), user);"吧
xxxllluuu
added a commit
to xxxllluuu/davinci
that referenced
this pull request
Aug 27, 2020
xxxllluuu
added a commit
to xxxllluuu/davinci
that referenced
this pull request
Aug 27, 2020
xxxllluuu
added a commit
to xxxllluuu/davinci
that referenced
this pull request
Sep 2, 2020
old-zsh
pushed a commit
to old-zsh/davinci
that referenced
this pull request
Sep 2, 2020
old-zsh
pushed a commit
to old-zsh/davinci
that referenced
this pull request
Sep 2, 2020
old-zsh
pushed a commit
to old-zsh/davinci
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1717