Open
Conversation
I've tried to keep the changeLinkColor content script as simple as possible so that background.js does the heavy lifting. This will reduce duplicate code between options.js, background.js and changeLinkColor.js, since the former 2 can now contain imports, whereas content scripts cannot.
colossatr0n
force-pushed
the
restore-link-highlight
branch
from
3d1b1d9 to
2b16c03
Compare
Contributor
Author
|
@edoreld I’ve been testing this for a couple weeks and everything works well. Could you look into testing/merging this? |
Owner
|
I'm not maintaining this extension anymore for lack of interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to keep the changeLinkColor content script as simple as possible so that background.js does the heavy lifting.
This will reduce duplicate code between options.js, background.js and changeLinkColor.js, since the former 2 can now contain imports, whereas content scripts cannot.