Display number of read URLs on options page.#26
Open
colossatr0n wants to merge 3 commits intoedoreld:masterfrom
Open
Display number of read URLs on options page.#26colossatr0n wants to merge 3 commits intoedoreld:masterfrom
colossatr0n wants to merge 3 commits intoedoreld:masterfrom
Conversation
colossatr0n
force-pushed
the
display-number-read
branch
from
d42fd77 to
292b748
Compare
edoreld
reviewed
May 12, 2022
edoreld
requested changes
Jan 12, 2023
| } | ||
|
|
||
| async function getVisitedCount() { | ||
| const obj = await chrome.storage.local.get("visited") |
Owner
There was a problem hiding this comment.
Error on calling this line
Uncaught (in promise) TypeError: Error in invocation of storage.get(optional [string|array|object] keys, function callback): No matching signature.
at getVisitedCount (options.js:24:44)
at HTMLDocument.<anonymous> (options.js:46:64)
I believe you need to use chrome.storage.local.get("visited", function(obj) instead, as done elsewhere in the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #25.