(fix): move regex out of fn scope#2
Merged
pabloes merged 2 commits intoOct 20, 2017
Conversation
… to lts/boron (6.11.4), also limit node versions because some dependencies are not working with node 7 in the specified versions, added yarn lock
…pe, so that it will not be created on each function call of isUrl()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the former implementation the regular expression was defined on each call of isUrl(), so this will everytime create a new expression. By relocating it to the outer scope it will be only created and just reused.
see: jsPerf