Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test #386

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix flaky test #386

merged 2 commits into from
Jan 31, 2025

Conversation

SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Jan 31, 2025

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run build).
  • Run npm run lint w/o errors.

after #372, applying changes sometimes takes a bit longer than 50ms, and this creates a race condition

workflow with this change has run 7 times without failure

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xuhdev xuhdev merged commit efc1dea into editorconfig:main Jan 31, 2025
9 checks passed
@SunsetTechuila SunsetTechuila deleted the fix-flaky-tests branch January 31, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants