-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to include x64 build guides #17
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Update README.md to include more build guides
- Loading branch information
commit 779345f3124ef2c5c0f496b0dbf493525f5d3746
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you wanna say the BUILD_TYPE should be set to
Release
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
Release
should be used to compile the dll for daily use. Release builds should be smaller and runs faster than Debug builds. However using the Debug one is also fine.There are 2 places where we can change the option. The first place is when we "Configure" the CMake project, we can specify a set of available configuration types in the
CMAKE_CONFIGURATION_TYPES
option. The second place is when we opened the project using VS, there is a drop down menu on the toolbar so we can select the configuration from the set.CMAKE_CONFIGURATION_TYPES
defaults toDebug;Release;MinSizeRel;RelWithDebInfo
and VS defaults to the first one, which isDebug
.Maybe I should call it "configuration type" instead of "build type". Do I need to change it or just remove the suggestion to use
Release
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release
. Otherwise, many people may forget.