Allow developers on Windows specify what kind of integrated terminal they use

[KalitaAlexey]

As #286 states,
Some developers want to use WSL as an integrated terminal.
Of course it is possible to add handling "bash.exe" or "bash*", but it's not very flexible.
It would be better if the developer could specify what kind of terminal one uses.

I know three kind of terminals:

• cmd
• powershell
• sh

A new configuration parameter, "rust.integratedTerminal.kind" should be added with the following values:

• null
• "cmd"
• "powershell"
• "sh"

The kind of the used integrated terminal will be determined when the extension activates. The extension will check if the new configuration parameter is set to some proper value and if it is, the extension will use it. Otherwise it will try to determine the kind of the used integrated terminal from the configuration parameter "terminal.integrated.shell.windows". If the extension cannot to determine it, then the extension will show the developer a quick pick with possible values. If the user dismisses the quick pick, then running Cargo command in an integrated terminal will not be possible.

If someone has something to say, please speak up.

[Gordon-F]

Maybe open VSCode issue with this enhancement?

[KalitaAlexey]

@Gordon-F,
It's not about VSCode. It's about how the extension executes Cargo commands. Depending on the kind of integrated terminal, the extension may transform executable/args/env.

[Gordon-F]

@KalitaAlexey I think this related not only for Rust. And kind of terminal should set using VSCode setting.

You can have similar problems (env var, path ) with Python\Go\etc.

[KalitaAlexey]

It seems you don't understand what the extension does.
Look at Terminal API.
It has the only one method, sendText.
The extension sets environment variables, executes commands etc.
Of course it is possible to extend Terminal to have such methods.

[tinaun]

ideally, the tasks shouldn't depend on what terminal you have open. using the tasks to just dump text in a terminal seems kinda awkward to me

[KalitaAlexey]

@tinaun,
That's how the API defined.
Setting environment variables, sequential execution, etc. is different on different terminals.

[KalitaAlexey]

I'll fix it in 3 days.
I'll not have enough time until the time.

[KalitaAlexey]

Everyone who is interested, please look at #315