Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript support, config and update dependencies #88

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

yuan-93
Copy link
Contributor

@yuan-93 yuan-93 commented Jun 3, 2024

Resolve #82 Migrate to Typescript

Changes:

  1. Add Typescript
  2. Add type dependencies @editorjs/editorjs
  3. Add tsconfig.json
  4. Convert Js files to Ts files
  5. Add .d.ts for @codexteam/icons
  6. Add vite-plugin-dts to generate types during build

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you. Could you please leave a single quotes in code formatting. And take a look on few comments. Also, please, increment a patch version

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@yuan-93
Copy link
Contributor Author

yuan-93 commented Jun 9, 2024

Sure, thanks for reviewing, I have amended the codes following your comments

Changes:

  1. Add single quote config to .editorconfig, update double quote to single quote
  2. Add and update all function return types
  3. Update unexpected line break
  4. Add jsdocs to all interfaces and properties
  5. Increment patch version

neSpecc
neSpecc previously approved these changes Jun 12, 2024
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@yuan-93
Copy link
Contributor Author

yuan-93 commented Jun 12, 2024

Changes

  1. Export ParagraphConfig and ParagraphData interfaces
  2. npm run build to update /dist folder

@neSpecc neSpecc merged commit bdeab6d into editor-js:master Jun 12, 2024
@neSpecc
Copy link
Contributor

neSpecc commented Jun 12, 2024

Thanks, @yuan-93l, great work. If you have time, you can help us migrate other tools to TypeScript. Let me know if you're interested.

@yuan-93
Copy link
Contributor Author

yuan-93 commented Jun 12, 2024

@neSpecc Thanks ! Yea sure, I can help out 😄

@neSpecc
Copy link
Contributor

neSpecc commented Jun 12, 2024

@neSpecc Thanks ! Yea sure, I can help out 😄

How about Nested List?

@yuan-93
Copy link
Contributor Author

yuan-93 commented Jun 12, 2024

Alright, let me check it out, can you open a migration to typescript issue for Nested List ? i cant find one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to TypeScript
2 participants