ability to change payload limit #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! I will review later this week and include on the next release |
|
Oh we also need to change the error message: @invalid_data_size_json JSX.encode!(%{error: "Data key must be smaller than 10KB"})Instead of being a module attribute we need a plain old private function that receives the max size I think. |
|
@edgurgel ok, do you want size to be formatted or given that the size can be any number of bytes we can just say X Bytes? |
|
We can just say X bytes. That's fine 👍 |
iurifq
reviewed
Oct 9, 2017
lib/poxa/event_handler.ex
Outdated
| @@ -62,7 +62,8 @@ defmodule Poxa.EventHandler do | |||
| The event data can't be greater than 10KB | |||
There was a problem hiding this comment.
Since now this limit is configurable, could you also update this comment to reflect that this is just the default value?
|
Thanks! I'm still fixing some stuff but I intend to release a new version tomorrow. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to change payload limit as per this issue #91