Fix typespecs spotted by dialyzer

edgurgel · Jul 19, 2014 · 00ba574 · 00ba574
1 parent 466bd91
commit 00ba574
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/lib/poxa/authorization_helper.ex b/lib/poxa/authorization_helper.ex
@@ -1,7 +1,7 @@
 defmodule Poxa.AuthorizationHelper do
   alias Poxa.Authentication
 
-  @spec is_authorized(:cowboy.req, any) :: {true, :cowboy.req, any} | {{false, binary}, :cowboy.req, nil}
+  @spec is_authorized(:cowboy_req.req, any) :: {true, :cowboy_req.req, any} | {{false, binary}, :cowboy_req.req, nil}
   def is_authorized(req, state) do
     {:ok, body, req} = :cowboy_req.body(req)
     {method, req} = :cowboy_req.method(req)

diff --git a/lib/poxa/presence_subscription.ex b/lib/poxa/presence_subscription.ex
@@ -10,6 +10,7 @@ defmodule Poxa.PresenceSubscription do
   More info at: http://pusher.com/docs/client_api_guide/client_presence_channels
   """
   @type user_id :: integer | binary # Maybe a json_term too?
+  @type user_info :: :jsx.json_term # Not sure
 
   alias Poxa.PusherEvent
   alias Poxa.Subscription

diff --git a/lib/poxa/pusher_event.ex b/lib/poxa/pusher_event.ex
@@ -5,6 +5,8 @@ defmodule Poxa.PusherEvent do
   Take a look at http://pusher.com/docs/pusher_protocol#events for more info
   """
 
+  alias Poxa.PresenceSubscription
+
   def valid?(event) do
     Enum.all?(["name", "data"], &Dict.has_key?(event, &1))
   end
@@ -152,7 +154,7 @@ defmodule Poxa.PusherEvent do
       {%{"socket_id" => "to_exclude123"},["a-channel"],"to_exclude123"}
 
   """
-  @spec parse_channels(Map.t) :: {:jsx.json_term,
+  @spec parse_channels(map) :: {:jsx.json_term,
                                   [binary] | :undefined,
                                   :undefined | binary}
   def parse_channels(message) do

diff --git a/lib/poxa/subscription.ex b/lib/poxa/subscription.ex
@@ -12,8 +12,9 @@ defmodule Poxa.Subscription do
   Returns :ok to public and private channels and
   {:presence, channel, channel_data} to presence channel
   """
-  @spec subscribe!(:jsx.json_term, binary) :: :ok | {:presence, binary, {PresenceSubscription.user_id,
-                                                                          :jsx.json_term}} | :error
+  @spec subscribe!(:jsx.json_term, binary) :: {:ok, binary}
+    | {:presence, binary, {PresenceSubscription.user_id, :jsx.json_term}}
+    | :error
   def subscribe!(data, socket_id) do
     channel = data["channel"]
     case channel do